-
-
Notifications
You must be signed in to change notification settings - Fork 84
An initial try at integrating CodeTailor with Runestone #867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ore components and supporting modules
…nto codetailor_merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done a quick look and left some initial comments in some of the files, and have a few higher level questions below:
- This is a BIG PR. I need some instructions on how to use/test the new features.
- What steps have you taken to ensure that activecode and parsons continue to work as they have in the past after your changes are applied?
- Have you tested this in a Docker container? I'm guessing you have not based on the use of the
requirements.txt
file. - More documentation of the code is needed. Someone is going to have to maintain this in the future.
Tagging @barbarer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not use requirements.txt
any additional dependencies should be added to the pyproject.toml
file for the book_server project with poetry
. It needs to handle all of the dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the requirements.txt
file and migrated all necessary dependencies to the pyproject.toml
file under projects>book_server
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file really needed? I see this and several other .csv
files and some .txt
files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The RST markup code has been deprecated for some time. How will we use these automatically generated parsons problems in PreTeXt books?
Note:
Changes Included:
Frontend: bases->rsptx->interactives->runestone
Backend: bases->rsptx->book_server_api->routers