[ADD] BaseViewModel에 EventState (SharedFlow) 추가 #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeeha
approved these changes
Jun 19, 2024
| data class ShowSnackBar(val message: String) : EventState | ||
| data class NetworkError(val message: String) : EventState | ||
| data class UnknownError(val message: String) : EventState | ||
| } |
There was a problem hiding this comment.
네이밍과 관련해서 가장 최근 pr에 코멘트 하나 달아뒀어요! 확인 부탁드립니다 :)
unam98
force-pushed
the
develop
branch
2 times, most recently
from
fb1f98f
to
f8525c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요
✨ 작업 내용
위와 같이 구성하면 좋을 것 같아서 BaseViewModel에 eventState (sharedFlow) 를 추가하였습니다.
✨ PR 포인트
📸 스크린샷/동영상