-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull Requestします #1
base: master
Are you sure you want to change the base?
Conversation
…to ffmpeg Project to provide autoconf files...)
Fix Makefile.am, Add 2GB over large file support.
Hi, Rupan I modified your comskip code to compile with Linux. (add some files to use autoconf) Debian GNU/Linux, Ubuntu, Mint, and FreeBSD would build comskip code by this change. Best Regards. |
I'm sorry, I didn't have time to look into this until today. I'm reviewing the changes now. |
Thanks for contributing your changes back! A couple of comments:
Great idea, adding the ffmpeg git as a subproject. It will take me some time to go over the changes included here, but if you can address the points above and submit another pull request it will help. Due to the size of the changes and other (personal) factors I probably won't have the time to complete a review of such a large change for at least 2-4 weeks. |
Thank you for reviewing. |
comskip_wrapper.sh: センチ秒のサポート
…iling with Fedora.
not .7 but .07
fix bug in pullreq#2
TODO: re-implement LoadSettings by using getopt.
fix issue #1
gleentea's fix -> exclude reliance on argtable2 -> minor fix for FreeBSD
In 64bit OS(?), len can be large positive number. HomeDir[len]='\0' causes buffer-overrun in this case. With ASLR, this buffer-overrun can be "sometimes" appeared as SegFault. Without ASLR, I didn't experience it as SegFault...
fix possible buffer-overrun
・Makefile.amの修正
・2GBを超える大きいサイズの .ts ファイルを読み込めない問題の対応
(参考 : http://masao.jpn.org/d/2004-12-21.html )