Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Requestします #1

Open
wants to merge 40 commits into
base: master
Choose a base branch
from
Open

Pull Requestします #1

wants to merge 40 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 30, 2013

・Makefile.amの修正
・2GBを超える大きいサイズの .ts ファイルを読み込めない問題の対応
 (参考 : http://masao.jpn.org/d/2004-12-21.html )

@hangingman
Copy link

Hi, Rupan

I modified your comskip code to compile with Linux. (add some files to use autoconf)
I would be grateful if you could merge this change.

Debian GNU/Linux, Ubuntu, Mint, and FreeBSD would build comskip code by this change.

Best Regards.

@ghost ghost assigned Rupan Jan 1, 2014
@Rupan
Copy link
Owner

Rupan commented Jan 1, 2014

I'm sorry, I didn't have time to look into this until today. I'm reviewing the changes now.

@Rupan
Copy link
Owner

Rupan commented Jan 1, 2014

Thanks for contributing your changes back! A couple of comments:

  1. Auto-generated files (e.g. aclocal.m4, config.h*, configure, etc) have been committed into the git repository. These are generally not committed there, but are shipped in release tarballs.
  2. line endings in comskip.c were converted to CRLF, there were dozens of whitespace changes, and removal of all commented code generates a huge diff which, while somewhat possible to filter with 'git diff -b', makes for an unmanageably large changeset (32,000 lines+!)

Great idea, adding the ffmpeg git as a subproject. It will take me some time to go over the changes included here, but if you can address the points above and submit another pull request it will help. Due to the size of the changes and other (personal) factors I probably won't have the time to complete a review of such a large change for at least 2-4 weeks.

@hangingman
Copy link

Thank you for reviewing.
It is very useful, especially (1)

turenar and others added 15 commits February 25, 2014 06:12
TODO: re-implement LoadSettings by using getopt.
fix #1
 - No longer depend on the argtable
conver line break
gleentea's fix
-> exclude reliance on argtable2
-> minor fix for FreeBSD
In 64bit OS(?), len can be large positive number.
HomeDir[len]='\0' causes buffer-overrun in this case.

With ASLR, this buffer-overrun can be "sometimes" appeared as SegFault.
Without ASLR, I didn't experience it as SegFault...
fix possible buffer-overrun
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants