name resolution 2.0: Add base Resolver and TopLevel pass #2456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CohenArthur
force-pushed
the
nr2.0-base-resolver
branch
from
6fe346b
to
a0acb1a
Compare
|
Noticed a couple issues already so putting it in draft, but reviews welcome! |
CohenArthur
commented
Jul 20, 2023
P-E-P
reviewed
Jul 20, 2023
CohenArthur
force-pushed
the
nr2.0-base-resolver
branch
from
a0acb1a
to
4103aa8
Compare
This was referenced Jul 26, 2023
CohenArthur
force-pushed
the
nr2.0-base-resolver
branch
2 times, most recently
from
9ab87c7
to
fa8645b
Compare
CohenArthur
force-pushed
the
nr2.0-base-resolver
branch
from
fa8645b
to
71a4aee
Compare
P-E-P
reviewed
Jul 31, 2023
CohenArthur
force-pushed
the
nr2.0-base-resolver
branch
2 times, most recently
from
45e9d3d
to
73ad6fa
Compare
This commit adds a first simple `NameResolutionContext` data structure, which will be used by all passes of the name resolution to store definitions and access them. Namely, it contains a few instances of `ForeverStack`, for each namespace we will be using. gcc/rust/ChangeLog: * Make-lang.in: Add new object file. * resolve/rust-name-resolution-context.cc: New file. * resolve/rust-name-resolution-context.h: New file.
The `TopLevel` pass takes care of collecting definitions, placing them in the proper namespaces, and making them accessible for later resolution passes like `Early` and `Late`. It is meant to be run in a fixed point fashion, as import resolution, macro resolution and macro expansion may generate multiple new definitions. gcc/rust/ChangeLog: * Make-lang.in: Add new object file. * resolve/rust-toplevel-name-resolver-2.0.cc: New file. * resolve/rust-toplevel-name-resolver-2.0.h: New file.
This causes complaints by our GCC 4.8 builder. gcc/rust/ChangeLog: * resolve/rust-forever-stack.hxx: assert() -> rust_assert()
CohenArthur
force-pushed
the
nr2.0-base-resolver
branch
from
73ad6fa
to
5fa332f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TopLevelvisitorThis commit adds a first simple
Resolverdata structure, which willbe used by all passes of the name resolution to store definitions and access
them. Namely, it contains a few instances of
ForeverStack, for eachnamespace we will be using.
The
TopLevelpass takes care of collecting definitions, placing themin the proper namespaces, and making them accessible for later resolution
passes like
EarlyandLate. It is meant to be run in a fixed pointfashion, as import resolution, macro resolution and macro expansion
may generate multiple new definitions.