Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup clang warnings #3244

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Cleanup clang warnings #3244

merged 3 commits into from
Nov 7, 2024

Conversation

CohenArthur
Copy link
Member

  • hir: Mark AttrVec::get_outer_attrs as override
  • typecheck: Remove unused parameter in TyTyCheckCallExpr
  • asm: Fix clang warnings

@CohenArthur
hir: Mark AttrVec::get_outer_attrs as override
be88e6f 
gcc/rust/ChangeLog:

	* hir/tree/rust-hir.h: Add override qualifier to overriden method.
@CohenArthur
typecheck: Remove unused parameter in TyTyCheckCallExpr
ab35fa6 
gcc/rust/ChangeLog:

	* typecheck/rust-tyty-call.h: Remove unused context member.
@CohenArthur
asm: Fix clang warnings
dd24b0d 
Fixes a couple of warnings thrown by clang, with mismatched class/struct
usages and unused members.

gcc/rust/ChangeLog:

	* ast/rust-expr.h: Remove invalid usage of `struct`.
	* backend/rust-compile-asm.h: Remove unused `translated` member.
	* backend/rust-compile-asm.cc (CompileAsm::CompileAsm): Remove usage
	of `translated` member.
	* checks/errors/rust-unsafe-checker.h: Mark visitor as `override`.
	* hir/tree/rust-hir-expr.h (struct AnonConst): Remove unused `locus`
	member.
philberty
philberty approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@philberty philberty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CohenArthur CohenArthur added this pull request to the merge queue Nov 7, 2024
Merged via the queue into Rust-GCC:master with commit b0d6abb Nov 7, 2024
12 checks passed
@CohenArthur CohenArthur mentioned this pull request Nov 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philberty philberty philberty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CohenArthur @philberty