Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use nr2.0 in typechecker #3253

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Use nr2.0 in typechecker #3253

merged 1 commit into from
Nov 21, 2024

Conversation

powerboat9
Copy link
Contributor

@powerboat9 powerboat9 commented Nov 19, 2024 •
edited
Loading

I probably missed a few spots, but this should cover most of the typechecker

@powerboat9 powerboat9 force-pushed the fix-ty branch 2 times, most recently from ce2c34f to ba54c5a Compare November 19, 2024 21:48
@P-E-P P-E-P self-requested a review November 20, 2024 15:34
@powerboat9
Use nr2.0 in typechecker
e9c784d 
I probably missed a few spots, but this should cover most of the type
checker.

gcc/rust/ChangeLog:

	* typecheck/rust-hir-type-check-expr.cc: Add includes.
	(TypeCheckExpr::visit): Use name resolver 2.0.
	(TypeCheckExpr::resolve_operator_overload): Likewise.
	(TypeCheckExpr::resolve_fn_trait_call): Likewise.
	* typecheck/rust-hir-type-check-path.cc
	(TypeCheckExpr::visit): Likewise.
	(TypeCheckExpr::resolve_segments): Likewise.
	* typecheck/rust-hir-type-check-type.cc
	(TypeCheckType::resolve_segments): Likewise.
	(ResolveWhereClauseItem::visit): Likewise.
	(TypeCheckType::visit): Avoid usage of
	Resolver::get_unit_type_node_id when handling TupleType, use
	name resolver 2.0 when handling QualifiedPathInType.

gcc/testsuite/ChangeLog:

	* rust/compile/nr2/exclude: Remove entries.

Signed-off-by: Owen Avery <[email protected]>
P-E-P
P-E-P approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@P-E-P P-E-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, missing spots will probably show up later with some failing tests.

@P-E-P P-E-P added this pull request to the merge queue Nov 21, 2024
Merged via the queue into Rust-GCC:master with commit 90454a9 Nov 21, 2024
12 checks passed
@powerboat9 powerboat9 deleted the fix-ty branch November 21, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-E-P P-E-P P-E-P approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@powerboat9 @P-E-P