Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle type path segments during late resolution 2.0 #3254

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Handle type path segments during late resolution 2.0 #3254

merged 1 commit into from
Nov 20, 2024

Conversation

powerboat9
Copy link
Contributor

No description provided.

@powerboat9
Handle type path segments during late resolution 2.0
7d3dd5b 
gcc/rust/ChangeLog:

	* resolve/rust-late-name-resolver-2.0.cc
	(Late::visit): Call DefaultResolver::visit when visiting
	TypePath.

gcc/testsuite/ChangeLog:

	* rust/compile/nr2/exclude: Remove entries.

Signed-off-by: Owen Avery <[email protected]>
P-E-P
P-E-P approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@P-E-P P-E-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If only there was a way to opt out of default visitor/resolver/things instead that would be great and prevent people from forgetting calls like this. Thank you!

@P-E-P P-E-P added this pull request to the merge queue Nov 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 20, 2024
@powerboat9
Copy link
Contributor Author

It looks like this didn't actually get merged

@P-E-P P-E-P added this pull request to the merge queue Nov 20, 2024
Merged via the queue into Rust-GCC:master with commit fc59e9c Nov 20, 2024
12 checks passed
@powerboat9 powerboat9 deleted the fix-args branch November 20, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-E-P P-E-P P-E-P approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@powerboat9 @P-E-P