Add a new CI step to detect raw issue references in commit messages #3255
Conversation
P-E-P
force-pushed
the
ci_issue_no_checker
branch
from
8ad72c6 to
bc86f63
Compare
|
I guess it should be fine, until it's not. But this will also reject a reference to some rust-lang bug, as it matches the first grep, but not the following that checks that every # is prefixed by our prefix. Also, I think the correct prefix should be |
P-E-P
force-pushed
the
ci_issue_no_checker
branch
from
bc86f63 to
8031eb2
Compare
If such case arise we should be able to ignore this step, it will appear in red but the merge queue should work anyway.
Ah nice, I forgot we had an issue for this, and I also forgot the exact prefix, I'll change this asap. |
P-E-P
force-pushed
the
ci_issue_no_checker
branch
from
8031eb2 to
8426429
Compare
Issue references shall now be used with the Rust GCC prefix in order to avoid mixing gccrs issues and GCC bugzilla PRs. ChangeLog: * .github/workflows/commit-format.yml: Add a new step to detect issue references in commit messages. Signed-off-by: Pierre-Emmanuel Patry <[email protected]>
P-E-P
force-pushed
the
ci_issue_no_checker
branch
from
8426429 to
384a206
Compare
|
Merge this so you can try this out one me in this pr #3256 currently i am doing it like this: |
| done; | ||
| if [ "$retval" -ne 0 ]; then | ||
| echo "Some raw issue references were found (eg. #4242)." | ||
| echo "You shall rewrite the faulty commit message with this format: Rust-GCC/gccrs#4242" |
There was a problem hiding this comment.
| echo "You shall rewrite the faulty commit message with this format: Rust-GCC/gccrs#4242" | |
| echo "Rewrite the faulty commit message with this format: Rust-GCC/gccrs#4242" |
| if [ "$retval" -ne 0 ]; then | ||
| echo "Some raw issue references were found (eg. #4242)." | ||
| echo "You shall rewrite the faulty commit message with this format: Rust-GCC/gccrs#4242" | ||
| echo "You may ignore this CI step if it represents a valid GCC bugzilla or external repository reference instead." |
There was a problem hiding this comment.
| echo "You may ignore this CI step if it represents a valid GCC bugzilla or external repository reference instead." | |
| echo "You may ignore this CI step if it represents a valid GCC bugzilla reference instead." |
Issue references shall now be used with the Rust GCC prefix in order to avoid mixing gccrs issues and GCC bugzilla PRs.
Fixes #3213.