Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gccrs: Made changes to AST::TraitImpl constructor for TypePath #3298

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sriganeshres
Copy link

@sriganeshres sriganeshres commented Dec 10, 2024

gcc/rust/ChangeLog:

* ast/rust-item.h: I have changed helper constructor for typepath to be a delegating constructor.

Fixes #3296

Copy link
Member

@philberty philberty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tthe formatting doesnt look quite right did you use clang format?

@sriganeshres
Copy link
Author

Tthe formatting doesnt look quite right did you use clang format?

Yes That is why it has passed the tests and i have also ran the command clang-format -i gcc/rust/ast/rust-item.h

@philberty
Copy link
Member

Ok this looks ok to merge but looks like you didnt sign your commit off:

"Sri Ganesh Thota probably has FSF Copyright Assignment. Check manually that the lack of DCO Sign-Off is allowed."

Or do you have FSF copyright assignment?

@sriganeshres
Copy link
Author

sriganeshres commented Dec 13, 2024

Ok this looks ok to merge but looks like you didnt sign your commit off:

"Sri Ganesh Thota probably has FSF Copyright Assignment. Check manually that the lack of DCO Sign-Off is allowed."

Or do you have FSF copyright assignment?

Well i have used git gcc-commit-mklog and i have configured that with my username and email. Should i add a line like Signed-by: XXXX

@sriganeshres sriganeshres force-pushed the chore-delegate-constructor branch 3 times, most recently from 919fa39 to 69ccd26 Compare December 13, 2024 17:40
gcc/rust/ChangeLog:

	* ast/rust-item.h: I have changed helper constructor for typepath
	to be a delegating constructor.

Signed-off-by: Sri Ganesh Thota <[email protected]>
@sriganeshres sriganeshres force-pushed the chore-delegate-constructor branch from 69ccd26 to 20600b8 Compare December 13, 2024 17:42
@CohenArthur CohenArthur added this pull request to the merge queue Dec 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Reviewer approved
Development

Successfully merging this pull request may close these issues.

Use a delegating constructor for AST::TraitImpl
3 participants