Resolve lang-item PathInExpressions in nr2.0 late resolver #3404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamnaddell
reviewed
Jan 31, 2025
| Definition (Analysis::Mappings::get ().get_lang_item_node ( | ||
| expr.get_lang_item ()))); | ||
| return; | ||
| } | ||
|
|
||
| auto resolved | ||
| = ctx.values.resolve_path (expr.get_segments ()).or_else ([&] () { |
There was a problem hiding this comment.
When I was looking at this code, I got lost trying to figure out what resolve_path does, and how forever stacks work, and missed that the important part was calling map_usage.
There was a problem hiding this comment.
no worries it's all good :) dealing with the macro expansion is already complex enough for one PR haha
gcc/rust/ChangeLog: * resolve/rust-late-name-resolver-2.0.cc (Late::visit): Special case lang item paths.
CohenArthur
force-pushed
the
nr2.0-lang-item-pathinexprs
branch
from
804009d to
991e72c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs #3094 so only review the last commit
@liamnaddell @powerboat9 how does that look to you?