Various fixes and improvements #406
Conversation
It's in the wrong place, and it's empty. There is also `.github/ISSUE_TEMPLATE/bug_report.md`, which is in the right place.
To clarify something I found hard to understand.
It mixes up `debug_printf!` and `debug_printfln!`.
nnethercote
requested review from
eddyb,
LegNeato,
Firestar99 and
schell
as code owners
|
Can you manually squash this PR? To not pollute history too much (You can't configure merge queue to squash on a per-PR basis, it only squashes all PRs or none... please github add that) |
|
I'd rather not squash the commits, because they are logically separate I'm a strong believer in using separate commits for logically separate changes, and not squashing unrelated commits. I put effort into this because separate commits make reviewing easier, they make version control archaeology easier, and they make bisection easier if a bug is introduced. Separate commits don't pollute history; if anything, squashing unrelated changes into a single commit pollutes history. (Of course, sometimes squashing is appropriate, e.g. when you have a messy commit series like "add feature" / "fix the test" / "run rustfmt" / "fix a typo in the test" where the commits aren't logically separate and merely reflect local version control history. This PR isn't one of those cases.) |
Add vote to this one: https://github.com/orgs/community/discussions/68723 |
A bunch of minor things I found while looking over this code.