Skip to content

Conversation

Firestar99
Copy link
Member

@Firestar99 Firestar99 commented Oct 14, 2025

Breaking changes

  • rename VectorOrScalar to ScalarOrVector to match spec expression used in subgroup intrinsics
  • changed publicly exported paths
    • spirv_std::vector::VectorOrScalar -> spirv_std::ScalarOrVector
    • spirv_std::scalar::Scalar -> spirv_std::Scalar
    • spirv_std::vector::Vector -> spirv_std::Vector
    • spirv_std::number::Number -> spirv_std::Number
    • spirv_std::integer::Integer -> spirv_std::Integer
    • spirv_std::integer::SignedInteger -> spirv_std::SignedInteger
    • spirv_std::integer::UnsignedInteger -> spirv_std::UnsignedInteger
    • spirv_std::float::Float -> spirv_std::Float
  • these are probably barely used outside of spirv-std directly

Changes

  • move Scalar traits (Number, Integer, SignedInteger, UnsignedInteger, Float) to mod scalar
  • simplify proc macro to declare Scalars and Vectors
  • move VectorOrScalar and Sealed to new mod vector_or_scalar
  • remove root-level mods integer, number, sealed
    • keep float since it has intrinsics

@Firestar99 Firestar99 force-pushed the compiletest-normalization branch from 065b526 to 121a661 Compare October 16, 2025 09:26
@Firestar99 Firestar99 mentioned this pull request Oct 21, 2025
@Firestar99 Firestar99 changed the base branch from compiletest-normalization to main October 22, 2025 09:44
@Firestar99 Firestar99 marked this pull request as ready for review October 22, 2025 09:45
Copy link
Member

@eddyb eddyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at this now, they could've been in a spirv_std::traits module from the start, but the consolidation from this PR is already most of the improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants