accept absolute target_dir_path and properly resolve relative ones with cargo_metadata
#442
+7
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no longer necessary since d416b65
Firestar99
force-pushed
the
example-profile-env-forwarding
branch
from
6187066 to
51798a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
The change described in the title has already been merged into main with d416b65 in #216. This PR merely serves to document said change, and to adopt the examples.
Thus, the actual contents of this PR is:
@eddyb asked me to split it out of #419 (comment)
(Are we ok with this sort of PR, or do you want it changed to reflect the actual contents of this PR?)