Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Unintern" DataInstForm (inlining its fields back into DataInstDef). #12

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

eddyb
Copy link
Collaborator

@eddyb eddyb commented Nov 6, 2024

Effectively undoes:

Some quick unscientific testing reveals no significant perf impact (i.e. the difference is lost in the noise).

The motivation for undoing this interning is the prospect of combining DataInstDef into NodeDef (as mentioned in #7), and for unrelated pragmatic reasons, NodeDef can't have its outputs interned (though long-term maybe we could intern the kind field, if really necessary, assuming we first take "child regions" out of it).

The one thing I realized too late there's no pre-existing consensus for, is the output_type, which used to be between kind and inputs (matching DataInstFormDef, in fact), while NodeDef's outputs is the last field.

The only argument to have outputs first is the let (out0, out1) = foo(in0, in1); style syntax (though pretty-printed SPIR-T omits the let), but I'm not sure that's worth flipping the order over.

@eddyb eddyb added this to the 0.5.0 milestone Nov 6, 2024
@eddyb eddyb enabled auto-merge November 6, 2024 21:33
Copy link
Collaborator

@LegNeato LegNeato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't understand the code yet, but the changes look pretty mechanical and clean stuff up nicely.

@eddyb eddyb added this pull request to the merge queue Nov 6, 2024
Merged via the queue into Rust-GPU:main with commit 5c42614 Nov 6, 2024
6 checks passed
@eddyb eddyb deleted the deform branch November 6, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants