Skip to content

Commit

Permalink
genirq/proc: Add missing space separator back
Browse files Browse the repository at this point in the history
The recent conversion of show_interrupts() to seq_put_decimal_ull_width()
caused a formatting regression as it drops a previosuly existing space
separator.

Add it back by unconditionally inserting a space after the interrupt
counts and removing the extra leading space from the chip name prints.

Fixes: f9ed1f7 ("genirq/proc: Use seq_put_decimal_ull_width() for decimal values")
Reported-by: Geert Uytterhoeven <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Tested-by: Geert Uytterhoeven <[email protected]>
Reviewed-by: David Wang <[email protected]>
Link: https://lore.kernel.org/all/87zfldt5g4.ffs@tglx
Closes: https://lore.kernel.org/all/[email protected]
  • Loading branch information
KAGA-KOKO committed Dec 3, 2024
1 parent ee3878b commit 9d9f204
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions kernel/irq/proc.c
Original file line number Diff line number Diff line change
Expand Up @@ -501,17 +501,18 @@ int show_interrupts(struct seq_file *p, void *v)

seq_put_decimal_ull_width(p, " ", cnt, 10);
}
seq_putc(p, ' ');

raw_spin_lock_irqsave(&desc->lock, flags);
if (desc->irq_data.chip) {
if (desc->irq_data.chip->irq_print_chip)
desc->irq_data.chip->irq_print_chip(&desc->irq_data, p);
else if (desc->irq_data.chip->name)
seq_printf(p, " %8s", desc->irq_data.chip->name);
seq_printf(p, "%8s", desc->irq_data.chip->name);
else
seq_printf(p, " %8s", "-");
seq_printf(p, "%8s", "-");
} else {
seq_printf(p, " %8s", "None");
seq_printf(p, "%8s", "None");
}
if (desc->irq_data.domain)
seq_printf(p, " %*lu", prec, desc->irq_data.hwirq);
Expand Down

0 comments on commit 9d9f204

Please sign in to comment.