Skip to content

Commit

Permalink
cifs: Fix parsing reparse point with native symlink in SMB1 non-UNICO…
Browse files Browse the repository at this point in the history
…DE session

SMB1 NT_TRANSACT_IOCTL/FSCTL_GET_REPARSE_POINT even in non-UNICODE mode
returns reparse buffer in UNICODE/UTF-16 format.

This is because FSCTL_GET_REPARSE_POINT is NT-based IOCTL which does not
distinguish between 8-bit non-UNICODE and 16-bit UNICODE modes and its path
buffers are always encoded in UTF-16.

This change fixes reading of native symlinks in SMB1 when UNICODE session
is not active.

Fixes: ed3e0a1 ("smb: client: implement ->query_reparse_point() for SMB1")
Signed-off-by: Pali Rohár <[email protected]>
Signed-off-by: Steve French <[email protected]>
  • Loading branch information
pali authored and Steve French committed Nov 25, 2024
1 parent 1f48660 commit f4ca4f5
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions fs/smb/client/smb1ops.c
Original file line number Diff line number Diff line change
Expand Up @@ -1000,12 +1000,11 @@ static int cifs_parse_reparse_point(struct cifs_sb_info *cifs_sb,
{
struct reparse_data_buffer *buf;
TRANSACT_IOCTL_RSP *io = rsp_iov->iov_base;
bool unicode = !!(io->hdr.Flags2 & SMBFLG2_UNICODE);
u32 plen = le16_to_cpu(io->ByteCount);

buf = (struct reparse_data_buffer *)((__u8 *)&io->hdr.Protocol +
le32_to_cpu(io->DataOffset));
return parse_reparse_point(buf, plen, cifs_sb, full_path, unicode, data);
return parse_reparse_point(buf, plen, cifs_sb, full_path, true, data);
}

static bool
Expand Down

0 comments on commit f4ca4f5

Please sign in to comment.