[net] Add Ethernet lengths and Header/Address types #1014
Conversation
|
Force-pushed with changes suggested by @bjorn3 . EDIT: I missed the answer to whether or not to use |
Nit: to be clear, that applies to the |
My bad, I forgot that |
rust/kernel/net/ethernet.rs
Outdated
| /// Return the unspecified Ethernet address | ||
| pub const fn get_address_unspecified() -> Address { | ||
| Address([0x00; ALEN]) | ||
| } |
There was a problem hiding this comment.
I was originally thinking about const ADDRESS_UNSPECIFIED: Address = Address([0x00; ALEN]); but this works too I guess. By the way does the C side have similar constants, or is it manually written everywhere?
Edit: Found eth_zero_addr() and eth_broadcast_addr().
There was a problem hiding this comment.
Yep! Those are the functions I originally copied from C, which is why I thought about making them functions first.
I could make them into associated methods to Address though? That'd mirror the way Ipv4Addr works IIRC
There was a problem hiding this comment.
Makes sense. And yeah, making them methods would be nice.
There was a problem hiding this comment.
I moved them to Address::broadcast() and Address::unspecified().
This patch adds a module to the `net` module of `kernel` that provides constants for ethernet lengths (address length, type length, etc), as well as the enumeration of all protocols currently understood by the network stack. The latter are represented as 16-bit integers in memory to simplify conversion to and from the types read directly from Ethernet II frames. This patch also contains a conversion from/to `u16`. The `ethernet` module also contains a `Header` abstraction that just wraps around `struct ethhdr` defined in the UAPI. There is a simple builder function implemented as well as getters for src/dst address, and protocol number. Signed-off-by: Amélie Gonzalez <[email protected]>
(proper patch note below)
I know this repo is sort of meant to stay as an archive as development has moved to mainline. I'm only based on
rustbecause I needed the fundamentals ofnet.This PR is just a showcase of some of the most uncontroversial and menial work (the kind you script with
sedeventually) I had to do in the course of a work project where I wrote the necessary abstractions to have a tunneling driver (including RTNL, NAPI, someDevicestuff, someSkBuffstuff, UDP Sockets, etc) working in Rust for Linux. I know the infrastructure fornetis slowly being added torust-nextby Tomonori FUJITA[1], and that base is needed for me to even begin to consider the idea of presenting any of the rest I have to that branch.I'm just looking for feedback, like protocol names, conventions used for naming structs, methods and enums. Anything that can be improved.
[1]: https://lore.kernel.org/rust-for-linux/[email protected]/T/#t
This patch adds a module to the
netmodule ofkernelthat provides enumerations with constants for ethernet lengths (address length, type length, etc), as well as the enumeration of all protocols currently understood by the network stack. The latter are represented as 16-bit integers in memory to simplify conversion to and from the types read directly from Ethernet II frames. This patch also contains a conversion from/tou16.The
ethernetmodule also contains aHeaderabstraction that just wraps aroundstruct ethhdrdefined in the UAPI. There is a simple builder function implemented as well as getters for src/dst address, and protocol number.