Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update docker images for arm #865

Merged
merged 1 commit into from
Mar 14, 2024
Merged

ci: Update docker images for arm #865

merged 1 commit into from
Mar 14, 2024

Conversation

LucasFA
Copy link
Contributor

@LucasFA LucasFA commented Mar 12, 2024

Commit message body:

See https://github.com/cross-rs/cross/wiki/Configuration#builddockerfile
for context regarding the $CROSS_BASE_IMAGE environment variable. Here, it
resolves toghcr.io/cross-rs/armv7-unknown-linux-gnueabihf:{{cross_version}}

Relies on docker caching instead of pre-building the image.

Cross made the change to the GHCR on https://github.com/cross-rs/cross/pull/609

Add newline at EOF for some files.

It could reasonably be considered to remove the dockerfile altogether and declare the
environment variables docs and apt installation script docs, example as part of the Cross.toml file.

It's just changing a few lines more, besides deleting the dockerfile. If that's deemed a good
option, I would gladly push it to this PR branch.

See https://github.com/cross-rs/cross/wiki/Configuration#builddockerfile
for context regarding the $CROSS_BASE_IMAGE environment variable. Here, it
resolves to
ghcr.io/cross-rs/armv7-unknown-linux-gnueabihf:{{cross_version}}

Relies on docker caching instead of pre-building the image.

Cross made the change to the GHCR on cross-rs/cross#609

Add newline at EOF for some files.
@est31 est31 merged commit 437d47f into RustAudio:master Mar 14, 2024
14 of 15 checks passed
@LucasFA LucasFA deleted the docker branch March 14, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants