-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds draft for maintainer guide #666
base: master
Are you sure you want to change the base?
Conversation
MAINTAINERS.md
Outdated
|
||
Please feel free to open an issue and discuss these if you have a suggestion. | ||
|
||
1. Do not merge your own code to main, unless of course its a trivial change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO such a rule is good if there is a large enough maintainer community behind it. In smaller projects, I think it is less viable. But if there is at least two maintainers where both are well available, why not.
I would move these instructions into a contributor guide unless there is a lot of these. Also maybe we need release rules (maybe just a checklist). |
oh yeah that makes way more sense. Ill go do that |
I moved it to the end but I do not know if I like this. It kinda comes out of nowhere. You got any ideas? |
You mean it is not clear what is the purpose of this section? |
should be good to merge now |
Let me know what you think :)