Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds draft for maintainer guide #666

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

adds draft for maintainer guide #666

wants to merge 3 commits into from

Conversation

dvdsk
Copy link
Collaborator

@dvdsk dvdsk commented Dec 23, 2024

Let me know what you think :)

MAINTAINERS.md Outdated

Please feel free to open an issue and discuss these if you have a suggestion.

1. Do not merge your own code to main, unless of course its a trivial change.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO such a rule is good if there is a large enough maintainer community behind it. In smaller projects, I think it is less viable. But if there is at least two maintainers where both are well available, why not.

@PetrGlad
Copy link
Collaborator

I would move these instructions into a contributor guide unless there is a lot of these. Also maybe we need release rules (maybe just a checklist).

@dvdsk
Copy link
Collaborator Author

dvdsk commented Dec 28, 2024

I would move these instructions into a contributor guide unless there is a lot of these. Also maybe we need release rules (maybe just a checklist).

oh yeah that makes way more sense. Ill go do that

@dvdsk
Copy link
Collaborator Author

dvdsk commented Dec 28, 2024

I moved it to the end but I do not know if I like this. It kinda comes out of nowhere. You got any ideas?

@PetrGlad
Copy link
Collaborator

PetrGlad commented Dec 29, 2024

You mean it is not clear what is the purpose of this section?
Rename the section to "Instructions for maintainers" or "Guidelines for maintainers", maybe?

@dvdsk
Copy link
Collaborator Author

dvdsk commented Dec 31, 2024

should be good to merge now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants