ssh-key: support for reading PPK format private keys #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eugeny
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements full support for PuTTY's version 2 and 3 key formats, including encryption and all supported key types.
Format documentation: https://tartarus.org/~simon/putty-snapshots/htmldoc/AppendixC.html#ppk
New code and deps are gated behind the
ppkfeature:argon2- decryption KDFhmac- key MAChex- for parsing the embedded MACKeys are decrypted immediately on parse, as PPK can't be cleanly integrated into the
KeyData::Encryptedarchitecture because the existing decryption code just assumes OpenSSH format. PPK's private key part does not include the key elements present in the public key and has both different order and format of the fields (except for DSA)New code is mostly confined in a separate
ppk.rsmodTests included