Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ed25519: bump rand_core to 0.9.0 #904

Closed
wants to merge 1 commit into from

Conversation

baloo
Copy link
Member

@baloo baloo commented Feb 16, 2025

No description provided.

@baloo baloo marked this pull request as draft February 16, 2025 03:45
@baloo baloo force-pushed the baloo/ed25519/rand_core-0.9 branch from 643838c to 49cc251 Compare February 16, 2025 04:07
@baloo baloo marked this pull request as ready for review February 16, 2025 04:07
@baloo baloo force-pushed the baloo/ed25519/rand_core-0.9 branch from 49cc251 to 1050909 Compare February 20, 2025 19:09
@baloo baloo force-pushed the baloo/ed25519/rand_core-0.9 branch from 1050909 to 8f57d6e Compare February 20, 2025 21:08
@json420
Copy link
Contributor

json420 commented Feb 22, 2025

As far as I can tell this is correct (but I'm new here, haha).

I'd love to see this move forward because this is needed to be able to use ml-dsa and e25519 together again.

In local testing, I can cargo add ed25519 from this branch, then cargo add ml-dsa from git master, and it plays nice as long as I add ml-dsa with --no-default-features.

If the ml-dsa pkcs8 feature is enabled, things blow up because ml-dsa is currently locked to pkcs8=0.11.0-rc.1. That's not a problem with this PR, just something I thought I'd note that needs fixing.

Anyway, I give this PR a 👍

@baloo
Copy link
Member Author

baloo commented Feb 23, 2025

closed in favor of #913

@baloo baloo closed this Feb 23, 2025
@baloo baloo deleted the baloo/ed25519/rand_core-0.9 branch February 23, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants