Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This adds support for the Swift Package manager #38

Merged
merged 8 commits into from
Mar 6, 2020
Merged

This adds support for the Swift Package manager #38

merged 8 commits into from
Mar 6, 2020

Conversation

mauricekraus
Copy link
Contributor

@mauricekraus mauricekraus commented Feb 22, 2020 •
edited
Loading

To address the problem discussed in #32, I have added support for the Swift Package Manager.

@mauricekraus
Copy link
Contributor Author

@fassko Is it possible to review/merge this one?

@fassko
Copy link
Member

fassko commented Mar 5, 2020

Thanks @mauricekraus I will try to do it in coming days.

fassko
fassko requested changes Mar 5, 2020
View reviewed changes
Package.swift Outdated Show resolved Hide resolved
Sources/RxAnimated/RxAnimated+animations.swift Outdated Show resolved Hide resolved
Tests/RxAnimatedTests/RxAnimatedTests.swift Outdated Show resolved Hide resolved
@mauricekraus
Copy link
Contributor Author

@fassko I resolved all your requests

@fassko fassko self-requested a review March 6, 2020 18:40
@fassko fassko merged commit 5bf45be into RxSwiftCommunity:master Mar 6, 2020
@rxswiftcommunity
Copy link

Thanks a lot for contributing @mauricekraus! I've invited you to join the
RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like
more information on what this means, check out our contributor guidelines
and feel free to reach out with any questions.

Generated by 🚫 dangerJS

@fassko
Copy link
Member

fassko commented Mar 6, 2020

Thanks @mauricekraus for your contribution! :)

@fassko
Copy link
Member

fassko commented Mar 6, 2020

🎉 Congrats

🚀 RxAnimated (0.7.0) successfully published
📅 March 6th, 21:37
🌎 https://cocoapods.org/pods/RxAnimated
👍 Tell your friends!

@Econa77 Econa77 mentioned this pull request Jan 2, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fassko fassko fassko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mauricekraus @fassko