Skip to content

Commit

Permalink
Marked up all failures for SpecTest_conversions
Browse files Browse the repository at this point in the history
  • Loading branch information
martindevans committed Jul 5, 2024
1 parent b66a39d commit b06ea39
Showing 1 changed file with 14 additions and 1 deletion.
15 changes: 14 additions & 1 deletion WebAssembly.Tests/Runtime/SpecTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,20 @@ public void SpecTest_const()
[TestMethod]
public void SpecTest_conversions()
{
var skips = new HashSet<uint> { 88, 89, 93, 133, 134, 139, 183, 187, 229, 234, 236 };
var skips = new HashSet<uint>
{
88, // Arithmetic operation resulted in an overflow
89, // Arithmetic operation resulted in an overflow
93, // No exception thrown. OverflowException exception was expected
133, // Arithmetic operation resulted in an overflow
134, // Arithmetic operation resulted in an overflow
139, // No exception thrown. OverflowException exception was expected
183, // Arithmetic operation resulted in an overflow
187, // No exception thrown. OverflowException exception was expected
229, // Arithmetic operation resulted in an overflow
234, // Arithmetic operation resulted in an overflow
236 // OverflowException exception was expected
};
if (!Environment.Is64BitProcess) // 32-bit JIT operates differently as of .NET Core 3.1.
skips.UnionWith([454, 455, 470, 471]);
SpecTestRunner.Run(Path.Combine("Runtime", "SpecTestData", "conversions"), "conversions.json", skips.Contains);
Expand Down

0 comments on commit b06ea39

Please sign in to comment.