Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add argument to login to Instaloader #39

Merged
merged 4 commits into from
Jan 13, 2025
Merged

Add argument to login to Instaloader #39

merged 4 commits into from
Jan 13, 2025

Conversation

RyanLua
Copy link
Owner

@RyanLua RyanLua commented Jan 13, 2025

Description

Adds a new argument to start an interactive login with Instaloader.

Related Issues

Closes #16

Changes Made

  • Add new --login argument which takes a username
  • Update previous arguments to use argparse metavar when needed
  • Add logic for logging in using Instaloader with interactive_login()

Checklist

  • I have tested these changes thoroughly.
  • I have reviewed my code for any potential errors or issues.
  • I have followed the code style guidelines for this project.

Additional Notes

Related to #15

Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
@RyanLua RyanLua added the enhancement New feature or request label Jan 13, 2025
@RyanLua RyanLua self-assigned this Jan 13, 2025
Copy link

github-actions bot commented Jan 13, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@RyanLua RyanLua marked this pull request as ready for review January 13, 2025 22:26
@Copilot Copilot bot review requested due to automatic review settings January 13, 2025 22:26

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/instawebhooks/parser.py:52

  • [nitpick] The help message could be more descriptive. Suggest updating it to: 'login to Instagram with username, starting an interactive login session.'
help="login to instagram with username"
@RyanLua RyanLua requested a review from Copilot January 13, 2025 22:46

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/instawebhooks/main.py:58

  • The error message is vague. Consider specifying the type of error that occurred during login.
An error happened during login. Check if the provided username exists.

src/instawebhooks/main.py:48

  • The new login functionality should be covered by tests to ensure it works as expected.
if args.login or args.interactive_login:
@RyanLua RyanLua merged commit 56294ea into main Jan 13, 2025
10 checks passed
@RyanLua RyanLua deleted the login-arg branch January 13, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant