Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SetBit method to modify one bit of a byte #501

Merged
merged 7 commits into from
Aug 18, 2023

Conversation

Himmelt
Copy link
Contributor

@Himmelt Himmelt commented Aug 15, 2023

Add SetBit method to modify one bit of a byte

S7.Net/Conversion.cs Outdated Show resolved Hide resolved
S7.Net/Conversion.cs Outdated Show resolved Hide resolved
Himmelt and others added 2 commits August 16, 2023 17:18
Co-authored-by: Günther Foidl <[email protected]>
Co-authored-by: Günther Foidl <[email protected]>
Copy link
Member

@mycroes mycroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm open to accepting this, needs some minor changes.

S7.Net/Conversion.cs Outdated Show resolved Hide resolved
S7.Net/Conversion.cs Outdated Show resolved Hide resolved
Copy link
Member

@mycroes mycroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you're on track, I thought let's make this perfect 🚀 Will you apply the suggestions to the SelectBit xmldoc as well?

S7.Net/Conversion.cs Outdated Show resolved Hide resolved
S7.Net/Conversion.cs Outdated Show resolved Hide resolved
S7.Net/Conversion.cs Outdated Show resolved Hide resolved
S7.Net/Conversion.cs Outdated Show resolved Hide resolved
@mycroes mycroes merged commit 22451bc into S7NetPlus:main Aug 18, 2023
5 checks passed
@mycroes
Copy link
Member

mycroes commented Aug 18, 2023

I'm not 100% sure examples should go in the summary, but I'll take another look at that after merging. Thanks for your contribution @Himmelt, I hope you enjoyed working on it!

@Himmelt Himmelt deleted the add_set_bit branch August 19, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants