forked from counsyl/hgvs
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/prioritise X over Y #5
Open
h-joshi
wants to merge
61
commits into
SACGF:master
Choose a base branch
from
kidsneuro-lab:feature/prioritise-XoverY
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update docker container definition to operate on port 8002 * Update to port 8002 * Update examples to work with the sample data
* Issue #18. Add pre-computed outputs for the valid files * Add readme * Add readme * Handle lookup failures * Update to use two sources * Update to use two sources * Add tests that use the ensembl and variant validator files as inputs for comparison * Refactor tests * Add commend to execute tests * Perform comparison tests * Add instructions for diff * add http retries * Add resiliency * Add complete comparison files
* Install validaotor * Add normalise script * Process both sources * Added report
Resolves issue #78
- Clearly defined API request and response models - Exposed additional parameters within the API - Moved testing to pytest-bdd - Added error handling
Exclude pyc files during build
Added examples based on updated API spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New flag
prioritise_X_over_Y
to prioritise chromosome X over Y if the same transcript exists in both loci.