use dependency injection User/LastActivity #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banshiAnton
changed the title
| const u = await User.findOne({ _id: id }) | ||
| !!u && recipients.push(id) | ||
| for (const userId of recipients_ids) { | ||
| const user = await userService.userRepo.findById(userId) |
There was a problem hiding this comment.
Can we use findByIds and do it in a single request?
| return user | ||
| } | ||
|
|
||
| async findExisted(login, email, phone) { |
There was a problem hiding this comment.
let's rename to findWhere
and use it like this:
findWhere({$or: [{login}]})
findWhere({$or: [{login}, {email}]})
findWhere({$or: [{login}, {email}, {phone}]})
|
|
||
| import { ERROR_STATUES } from '../../../../constants/errors.js' | ||
|
|
||
| class UserAuthOperation { |
There was a problem hiding this comment.
should it be UserAuthService ?
There was a problem hiding this comment.
or even this can be a part of UserService
banshiAnton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SK-80
SK-83