Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conversation di #91

Merged
merged 30 commits into from
Mar 12, 2024
Merged

Conversation di #91

merged 30 commits into from
Mar 12, 2024

Conversation

banshiAnton
Copy link
Collaborator

@banshiAnton banshiAnton commented Mar 7, 2024 •
edited
Loading

SK-81
SK-89

@banshiAnton
add conversation providers
4256445
@banshiAnton
add conversation DI
d2a89e1
@banshiAnton
create update conversation operation
fdc2ac1
@banshiAnton
it can use ConversationListOperation
7aacf7a
@banshiAnton
it can use ConversationDeleteOperation
46b5fc2
@banshiAnton
it can use ConversationDeleteOperation
a06e026
@banshiAnton
it can list participants
257fe28
@banshiAnton
it can use create message operation
4e43323
@banshiAnton
it can edit messag
dacd62d
@banshiAnton
it can read messages
c312f76
@banshiAnton
it can delete messages
ed6eee2
@banshiAnton
it can list messages
42713db
@banshiAnton
use conversation/messages DI
029fea6
@banshiAnton
start conversation event notifications
d4df9ae
@banshiAnton
update conversation event/deliver messages
6677640
@banshiAnton
add model proxy
fce7123
@banshiAnton
update models/mappers
ca14551
@banshiAnton
remove old mapper
d20c557
@banshiAnton
start XMPP conversation/message DI
e0e52cc
@banshiAnton
use user native_id
4482ca6
@banshiAnton
create ConversationServiceXMPP
9da0c3f
@banshiAnton
create message DI XMPP implementation
382b172
@banshiAnton
update XMPP adapter
be7d085
@banshiAnton
user user as argument
7624272
@banshiAnton banshiAnton requested a review from IgorKhomenko March 7, 2024 12:22
IgorKhomenko
IgorKhomenko approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@IgorKhomenko IgorKhomenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some questions:

  1. what's the idea behind originalFields and what's the difference between it and visibleFields?
  2. some models still use hiddenFields, but I do not see it's defined in app/new_models/base.js

@banshiAnton banshiAnton merged commit 81171f8 into main Mar 12, 2024
@Oleksandr1414 Oleksandr1414 deleted the conversation-DI branch October 24, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgorKhomenko IgorKhomenko IgorKhomenko approved these changes

@Oleksandr1414 Oleksandr1414 Oleksandr1414 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@banshiAnton @IgorKhomenko @Oleksandr1414