-
-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[READY] v2.0: Support DSA and ECDSA signing keys #705
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnyshields
changed the title
Ec dsa redux
[WIP - NOT READY] v2.0: Support DSA and ECDSA signing keys
Jul 10, 2024
14 tasks
johnnyshields
force-pushed
the
ec-dsa-redux
branch
from
July 10, 2024 19:40
e92177f
to
f771caa
Compare
@pitbulk this is ready for your initial review. I'll give it another pass tomorrow but the core changes and tests are basically working 🎉 |
johnnyshields
changed the title
[WIP - NOT READY] v2.0: Support DSA and ECDSA signing keys
[PLEASE REVIEW BUT DO NOT MERGE] v2.0: Support DSA and ECDSA signing keys
Jul 11, 2024
…y PEM values, including the `RubySaml::Util#format_cert` and `#format_private_key` methods. Introduces new `RubySaml::PemFormatter` module.
johnnyshields
force-pushed
the
ec-dsa-redux
branch
12 times, most recently
from
July 13, 2024 14:52
4680d8d
to
9430fe9
Compare
johnnyshields
changed the title
[PLEASE REVIEW BUT DO NOT MERGE] v2.0: Support DSA and ECDSA signing keys
[READY] v2.0: Support DSA and ECDSA signing keys
Jul 13, 2024
johnnyshields
force-pushed
the
ec-dsa-redux
branch
from
July 13, 2024 15:03
9430fe9
to
f9cbf62
Compare
@pitbulk FYI I am now running this branch in prod without issue. |
@johnnyshields, merged this one but rubocop needs to be fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #661
Replaces #683
Depends on #711, please merge it first.
Currently RubySaml supports only RSA keys. The SAML standard can also support ECDSA and DSA keys. This PR adds support for both:
JRuby supports DSA but cannot support ECDSA due to this issue.
You may not use EC/DSA keys for encryption. An
ArgumentError
is raised if you attempt to do so.It includes the following changes, which are all done in a backward compatible manner:
settings.security[:signature_method]
now ignores the "rsa" component of its user-set value and automatically uses whatever type of SP signing public key you actually set (e.g. a DSA key) plus the "sha" component of the value.settings.security[:signature_method]
supports shortcut values:sha1
,:sha256
, etc.:rsa_sha256
,:dsa_sha256
etc. also work, but as per above the "rsa"/"dsa" are ignored in favor of the SP public key type.settings.security[:digest_method]
supports shortcut valuessha1
,sha256
, etc.XMLSecurity::Crypto
is extracted fromXMLSecurity::Document
DONE: