Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make hardier #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make hardier #19

wants to merge 2 commits into from

Conversation

schorlton
Copy link

I suppose it's a bit hard to see the diffs as Github doesn't account for moved files, but in summary:

  1. Set -euo pipefail to make it fail when a subcommand fails or if undefined variables
  2. Add flag to run BLAST analysis
  3. Expect all tools to be in PATH. A user should symlink them into PATH or change the script if not so.
  4. Define variables with their defaults as was previous set.
  5. Bump version

Thanks for your consideration!

@SAMtoBAM
Copy link
Owner

SAMtoBAM commented Feb 1, 2022

Hi there,
Sorry for the late reply.
I think 'make hardier' is the appropriate title, it has been something in the back of my head for a bit now
So taking your nudge I am rewriting somethings to make it easier to use.
Due to the branch conflicts and other things I was adding in the mean time, I will just add a new version of MUM&Co (3.8) soon separately.

  1. I will add this as you suggested.
  2. I will add the blast option
  3. Agreed, were you specifically referring to the BLAST step?
  4. I am adding defined defaults

On top of this it will now check to see if all the variables are set and warn you and exit if they are found to be empty etc.

Thanks for the suggestions

@SAMtoBAM
Copy link
Owner

SAMtoBAM commented Feb 1, 2022

Added v3.8 now which should be much more hardier
Thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants