Skip to content

Integrate SAP jmc agent into SapMachine #2024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Aug 14, 2025
Merged

Integrate SAP jmc agent into SapMachine #2024

merged 27 commits into from
Aug 14, 2025
+206 −0

Conversation

schmelter-sap
Copy link
Member

@schmelter-sap schmelter-sap commented Jul 30, 2025 •
edited
Loading

This integrates the SAP jmc agent into SapMachine. The new configure flag '--with-sap-jmc-agent=', when pointed to a directory containing the needed agent jar files, will add the "-jmcagent:" flag and the JVMTI.jmc_agent_load jcmd.

To test you can find builds of the agent at /sapmnt/sapjvm_work/openjdk/tools/sap-agent.

Use "-jmcagent:help" to get the help output.

fixes #2023

@SapMachine
Copy link
Member

Hello @schmelter-sap, this pull request fulfills all formal requirements.

MBaesken
MBaesken reviewed Jul 31, 2025
View reviewed changes
MBaesken
MBaesken reviewed Jul 31, 2025
View reviewed changes
MBaesken
MBaesken reviewed Jul 31, 2025
View reviewed changes
@SapMachine
Copy link
Member

Hello @schmelter-sap, this pull request fulfills all formal requirements.

@SapMachine
Copy link
Member

Hello @schmelter-sap, this pull request fulfills all formal requirements.

@SapMachine
Copy link
Member

Hello @schmelter-sap, this pull request fulfills all formal requirements.

MBaesken
MBaesken reviewed Aug 1, 2025
View reviewed changes
MBaesken
MBaesken reviewed Aug 1, 2025
View reviewed changes
@SapMachine
Copy link
Member

Hello @schmelter-sap, this pull request fulfills all formal requirements.

1 similar comment
@SapMachine
Copy link
Member

Hello @schmelter-sap, this pull request fulfills all formal requirements.

@SapMachine
Copy link
Member

Hello @schmelter-sap, this pull request fulfills all formal requirements.

RealCLanger
RealCLanger requested changes Aug 7, 2025
View reviewed changes
Copy link
Member

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall but I think the date in the SapMachine comments should be adapted to something close to today, otherwise it could be misleading when e.g. looking at issues later on.

@SapMachine
Copy link
Member

Hello @schmelter-sap, this pull request fulfills all formal requirements.

@SapMachine
Copy link
Member

Hello @schmelter-sap, this pull request fulfills all formal requirements.

@raeessap
Copy link

retest validate-pr-26-windows_x86_64

2 similar comments
@raeessap
Copy link

retest validate-pr-26-windows_x86_64

@raeessap
Copy link

retest validate-pr-26-windows_x86_64

@SapMachine
Copy link
Member

Hello @schmelter-sap, this pull request fulfills all formal requirements.

@SapMachine
Copy link
Member

Hello @schmelter-sap, this pull request fulfills all formal requirements.

@RealCLanger RealCLanger merged commit 99969a6 into SAP:sapmachine Aug 14, 2025
79 of 81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBaesken MBaesken MBaesken approved these changes

@RealCLanger RealCLanger RealCLanger approved these changes

@ArnoZeller ArnoZeller Awaiting requested review from ArnoZeller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add suport for SAP JMC agent
5 participants
@schmelter-sap @SapMachine @raeessap @MBaesken @RealCLanger