Make ABAP language version optional and set standard as default (#149)

* Make ALV optional and set standard as default * Fix line length * Remove Abap Language Version in types Co-authored-by: Michael Schneider <[email protected]>
SAP · Aug 4, 2021 · ecbc90d · ecbc90d
1 parent 5086ac4
commit ecbc90d
Show file tree

Hide file tree

Showing 28 changed files with 47 additions and 67 deletions.
diff --git a/file-formats/chkc/chkc.json b/file-formats/chkc/chkc.json
@@ -40,14 +40,14 @@
             "Standard",
             "ABAP for key user extensibility",
             "ABAP cloud development"
-          ]
+          ],
+          "default": "standard"
         }
       },
       "additionalProperties": false,
       "required": [
         "description",
-        "originalLanguage",
-        "abapLanguageVersion"
+        "originalLanguage"
       ]
     },
     "parentCategory": {

diff --git a/file-formats/chkc/examples/z_aff_example_chkc.chkc.json b/file-formats/chkc/examples/z_aff_example_chkc.chkc.json
@@ -2,7 +2,6 @@
   "$schema": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/chkc/chkc.json",
   "header": {
     "description": "Example CHKC for ABAP file formats",
-    "originalLanguage": "EN",
-    "abapLanguageVersion": "standard"
+    "originalLanguage": "EN"
   }
 }
diff --git a/file-formats/chkc/type/zif_atc_aff_chkc_v1.intf.json b/file-formats/chkc/type/zif_atc_aff_chkc_v1.intf.json
@@ -2,7 +2,6 @@
   "$schema": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/intf/intf.json",
   "header": {
     "description": "CHKC AFF Types",
-    "originalLanguage": "EN",
-    "abapLanguageVersion": "standard"
+    "originalLanguage": "EN"
   }
 }
diff --git a/file-formats/chko/chko.json b/file-formats/chko/chko.json
@@ -40,14 +40,14 @@
             "Standard",
             "ABAP for key user extensibility",
             "ABAP cloud development"
-          ]
+          ],
+          "default": "standard"
         }
       },
       "additionalProperties": false,
       "required": [
         "description",
-        "originalLanguage",
-        "abapLanguageVersion"
+        "originalLanguage"
       ]
     },
     "category": {

diff --git a/file-formats/chko/examples/z_aff_example_chko.chko.json b/file-formats/chko/examples/z_aff_example_chko.chko.json
@@ -2,8 +2,7 @@
   "$schema": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/chko/chko.json",
   "header": {
     "description": "Example CHKO for ABAP file formats",
-    "originalLanguage": "EN",
-    "abapLanguageVersion": "standard"
+    "originalLanguage": "EN"
   },
   "category": "Z_AFF_EXAMPLE_CHKC",
   "implementingClass": "ZCL_CI_TEST_AFF_EXAMPLE_CHECK",

diff --git a/file-formats/chko/type/zif_atc_aff_chko_v1.intf.json b/file-formats/chko/type/zif_atc_aff_chko_v1.intf.json
@@ -2,7 +2,6 @@
   "$schema": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/intf/intf.json",
   "header": {
     "description": "CHKO AFF Types",
-    "originalLanguage": "EN",
-    "abapLanguageVersion": "standard"
+    "originalLanguage": "EN"
   }
 }
diff --git a/file-formats/chkv/chkv.json b/file-formats/chkv/chkv.json
@@ -40,14 +40,14 @@
             "Standard",
             "ABAP for key user extensibility",
             "ABAP cloud development"
-          ]
+          ],
+          "default": "standard"
         }
       },
       "additionalProperties": false,
       "required": [
         "description",
-        "originalLanguage",
-        "abapLanguageVersion"
+        "originalLanguage"
       ]
     },
     "remoteEnabled": {

diff --git a/file-formats/chkv/type/zif_atc_aff_chkv_v1.intf.json b/file-formats/chkv/type/zif_atc_aff_chkv_v1.intf.json
@@ -2,7 +2,6 @@
   "$schema": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/chkv/chkv.json",
   "header": {
     "description": "AFF: ATC check variant v1",
-    "originalLanguage": "EN",
-    "abapLanguageVersion": "standard"
+    "originalLanguage": "EN"
   }
 }
diff --git a/file-formats/clas/clas.json b/file-formats/clas/clas.json
@@ -40,14 +40,14 @@
             "Standard",
             "ABAP for key user extensibility",
             "ABAP cloud development"
-          ]
+          ],
+          "default": "standard"
         }
       },
       "additionalProperties": false,
       "required": [
         "description",
-        "originalLanguage",
-        "abapLanguageVersion"
+        "originalLanguage"
       ]
     },
     "category": {

diff --git a/file-formats/clas/examples/zcl_aff_example.clas.json b/file-formats/clas/examples/zcl_aff_example.clas.json
@@ -2,8 +2,7 @@
   "$schema": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/clas/clas.json",
   "header": {
     "description": "Example class for ABAP file formats",
-    "originalLanguage": "EN",
-    "abapLanguageVersion": "standard"
+    "originalLanguage": "EN"
   },
   "fixPointArithmetic": true,
   "types": [

diff --git a/file-formats/clas/type/zif_oo_aff_clas_v1.intf.json b/file-formats/clas/type/zif_oo_aff_clas_v1.intf.json
@@ -2,7 +2,6 @@
   "$schema": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/intf/intf.json",
   "header": {
     "description": "AFF: Interface v1",
-    "originalLanguage": "EN",
-    "abapLanguageVersion": "standard"
+    "originalLanguage": "EN"
   }
 }
diff --git a/file-formats/enhs/enhs.json b/file-formats/enhs/enhs.json
@@ -40,14 +40,14 @@
             "Standard",
             "ABAP for key user extensibility",
             "ABAP cloud development"
-          ]
+          ],
+          "default": "standard"
         }
       },
       "additionalProperties": false,
       "required": [
         "description",
-        "originalLanguage",
-        "abapLanguageVersion"
+        "originalLanguage"
       ]
     },
     "configuration": {

diff --git a/file-formats/enhs/examples/z_aff_example_enhs.enhs.json b/file-formats/enhs/examples/z_aff_example_enhs.enhs.json
@@ -2,8 +2,7 @@
   "$schema": "http://github.com/sap/abap-file-formats/blob/main/file-formats/enhs/enhs.json",
   "header": {
     "description": "Example ENHS for ABAP file formats",
-    "originalLanguage": "EN",
-    "abapLanguageVersion": "standard"
+    "originalLanguage": "EN"
   },
   "configuration": {
     "tool": "badiDefinition"

diff --git a/file-formats/enhs/type/zif_seef_aff_enhs_v1.intf.json b/file-formats/enhs/type/zif_seef_aff_enhs_v1.intf.json
@@ -2,7 +2,6 @@
   "$schema": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/intf/intf.json",
   "header": {
     "description": "ENHS AFF Type",
-    "originalLanguage": "EN",
-    "abapLanguageVersion": "standard"
+    "originalLanguage": "EN"
   }
 }
diff --git a/file-formats/fugr/examples/z_aff_example_fugr.fugr.json b/file-formats/fugr/examples/z_aff_example_fugr.fugr.json
@@ -2,8 +2,7 @@
   "$schema": "http://github.com/sap/abap-file-formats/blob/main/file-formats/fugr/fugr.json",
   "header": {
     "description": "Example FUGR for ABAP file formats",
-    "originalLanguage": "EN",
-    "abapLanguageVersion": "standard"
+    "originalLanguage": "EN"
   },
   "fixPointArithmetic": true
 }
diff --git a/file-formats/fugr/fugr.json b/file-formats/fugr/fugr.json
@@ -40,14 +40,14 @@
             "Standard",
             "ABAP for key user extensibility",
             "ABAP cloud development"
-          ]
+          ],
+          "default": "standard"
         }
       },
       "additionalProperties": false,
       "required": [
         "description",
-        "originalLanguage",
-        "abapLanguageVersion"
+        "originalLanguage"
       ]
     },
     "fixPointArithmetic": {

diff --git a/file-formats/fugr/type/zif_fb_aff_fugr_v1.intf.json b/file-formats/fugr/type/zif_fb_aff_fugr_v1.intf.json
@@ -2,7 +2,6 @@
   "$schema": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/intf/intf.json",
   "header": {
     "description": "AFF type for FUGR objects",
-    "originalLanguage": "EN",
-    "abapLanguageVersion": "standard"
+    "originalLanguage": "EN"
   }
 }
diff --git a/file-formats/fugr/type/zif_fb_aff_func_v1.intf.json b/file-formats/fugr/type/zif_fb_aff_func_v1.intf.json
@@ -2,7 +2,6 @@
   "$schema": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/intf/intf.json",
   "header": {
     "description": "AFF type for FUNC objects",
-    "originalLanguage": "EN",
-    "abapLanguageVersion": "standard"
+    "originalLanguage": "EN"
   }
 }
diff --git a/file-formats/fugr/type/zif_fb_aff_reps_v1.intf.json b/file-formats/fugr/type/zif_fb_aff_reps_v1.intf.json
@@ -2,7 +2,6 @@
   "$schema": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/intf/intf.json",
   "header": {
     "description": "AFF type for REPS objects",
-    "originalLanguage": "EN",
-    "abapLanguageVersion": "standard"
+    "originalLanguage": "EN"
   }
 }
diff --git a/file-formats/intf/examples/zif_aff_example.intf.json b/file-formats/intf/examples/zif_aff_example.intf.json
@@ -2,8 +2,7 @@
   "$schema": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/intf/intf.json",
   "header": {
     "description": "Example interface for ABAP file formats",
-    "originalLanguage": "EN",
-    "abapLanguageVersion": "standard"
+    "originalLanguage": "EN"
   },
   "types": [
     {

diff --git a/file-formats/intf/intf.json b/file-formats/intf/intf.json
@@ -40,14 +40,14 @@
             "Standard",
             "ABAP for key user extensibility",
             "ABAP cloud development"
-          ]
+          ],
+          "default": "standard"
         }
       },
       "additionalProperties": false,
       "required": [
         "description",
-        "originalLanguage",
-        "abapLanguageVersion"
+        "originalLanguage"
       ]
     },
     "category": {

diff --git a/file-formats/intf/type/zif_oo_aff_intf_v1.intf.json b/file-formats/intf/type/zif_oo_aff_intf_v1.intf.json
@@ -2,7 +2,6 @@
   "$schema": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/intf/intf.json",
   "header": {
     "description": "AFF: Interface v1",
-    "originalLanguage": "EN",
-    "abapLanguageVersion": "standard"
+    "originalLanguage": "EN"
   }
 }
diff --git a/file-formats/nrob/examples/z_aff_nr.nrob.json b/file-formats/nrob/examples/z_aff_nr.nrob.json
@@ -2,8 +2,7 @@
   "$schema": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/nrob/nrob.json",
   "header": {
     "description": "Aff example object for type NROB",
-    "originalLanguage": "EN",
-    "abapLanguageVersion": "standard"
+    "originalLanguage": "EN"
   },
   "interval": {
     "numberLengthDomain": "NUM10",

diff --git a/file-formats/nrob/nrob.json b/file-formats/nrob/nrob.json
@@ -40,14 +40,14 @@
             "Standard",
             "ABAP for key user extensibility",
             "ABAP cloud development"
-          ]
+          ],
+          "default": "standard"
         }
       },
       "additionalProperties": false,
       "required": [
         "description",
-        "originalLanguage",
-        "abapLanguageVersion"
+        "originalLanguage"
       ]
     },
     "interval": {

diff --git a/file-formats/nrob/type/zif_nr_aff_nrob_v1.intf.json b/file-formats/nrob/type/zif_nr_aff_nrob_v1.intf.json
@@ -2,7 +2,6 @@
   "$schema": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/intf/intf.json",
   "header": {
     "description": "Interface with the NROB AFF Type",
-    "originalLanguage": "EN",
-    "abapLanguageVersion": "standard"
+    "originalLanguage": "EN"
   }
 }
diff --git a/file-formats/typesUsedForAll/zif_aff_types_v1.intf.abap b/file-formats/typesUsedForAll/zif_aff_types_v1.intf.abap
@@ -3,11 +3,13 @@ INTERFACE zif_aff_types_v1 PUBLIC.
   "! <p class="shorttext">ABAP Language Version (Source Code Objects)</p>
   "! ABAP language version for source code objects
   "! $values {@link zif_aff_types_v1.data:co_abap_language_version_src}
+  "! $default {@link zif_aff_types_v1.data:co_abap_language_version_src.standard}
   TYPES ty_abap_language_version_src TYPE c LENGTH 1.
 
   CONSTANTS:
     "! <p class="shorttext">ABAP Language Version (Source Code Objects)</p>
-    "! ABAP language version for source code objects. For non-source-code objects use
+    "! ABAP language version for source code objects like CLAS, INTF, FUGR or PROG.
+    "! Other source code objects (f.ex. DDLS) and non-source code objects have to use
     "! {@link zif_aff_types_v1.data:ty_abap_language_version }
     BEGIN OF co_abap_language_version_src,
       "! <p class="shorttext">Standard</p>
@@ -24,6 +26,7 @@ INTERFACE zif_aff_types_v1 PUBLIC.
   "! <p class="shorttext">ABAP Language Version</p>
   "! ABAP language version
   "! $values {@link zif_aff_types_v1.data:co_abap_language_version}
+  "! $default {@link zif_aff_types_v1.data:co_abap_language_version.standard}
   TYPES ty_abap_language_version TYPE c LENGTH 1.
 
   CONSTANTS:
@@ -44,7 +47,6 @@ INTERFACE zif_aff_types_v1 PUBLIC.
   "! <p class="shorttext">Description</p>
   "! Description with 60 characters
   TYPES ty_description_60 TYPE c LENGTH 60.
-
   "! <p class="shorttext">Description</p>
   "! Description with 100 characters
   TYPES ty_description_100 TYPE c LENGTH 100.
@@ -67,7 +69,6 @@ INTERFACE zif_aff_types_v1 PUBLIC.
       original_language     TYPE sy-langu,
       "! <p class="shorttext">ABAP Language Version (source code object)</p>
       "! ABAP language version for source code objects
-      "! $required
       abap_language_version TYPE ty_abap_language_version_src,
     END OF ty_header_60_src.
 
@@ -85,7 +86,6 @@ INTERFACE zif_aff_types_v1 PUBLIC.
       original_language     TYPE sy-langu,
       "! <p class="shorttext">ABAP Language Version</p>
       "! ABAP language version
-      "! $required
       abap_language_version TYPE ty_abap_language_version,
     END OF ty_header_60.
 
@@ -103,7 +103,6 @@ INTERFACE zif_aff_types_v1 PUBLIC.
       original_language     TYPE sy-langu,
       "! <p class="shorttext">ABAP Language Version</p>
       "! ABAP language version
-      "! $required
       abap_language_version TYPE ty_abap_language_version,
     END OF ty_header_100.
 

diff --git a/file-formats/typesUsedForAll/zif_aff_types_v1.intf.json b/file-formats/typesUsedForAll/zif_aff_types_v1.intf.json
@@ -2,7 +2,6 @@
   "$schema": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/intf/intf.json",
   "header": {
     "description": "General types reusable in AFF",
-    "originalLanguage": "EN",
-    "abapLanguageVersion": "standard"
+    "originalLanguage": "EN"
   }
 }
diff --git a/file-formats/typesUsedForClasAndIntf/zif_oo_aff_types_v1.intf.json b/file-formats/typesUsedForClasAndIntf/zif_oo_aff_types_v1.intf.json
@@ -2,7 +2,6 @@
   "$schema": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/intf/intf.json",
   "header": {
     "description": "Common types for classes and interfaces",
-    "originalLanguage": "EN",
-    "abapLanguageVersion": "standard"
+    "originalLanguage": "EN"
   }
 }