Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ABAP CDS Syntax Highlighter for .acds files #371

Closed
BeckerWdf opened this issue Jun 29, 2022 · 2 comments · Fixed by #372
Closed

Use ABAP CDS Syntax Highlighter for .acds files #371

BeckerWdf opened this issue Jun 29, 2022 · 2 comments · Fixed by #372

Comments

@BeckerWdf
Copy link
Contributor

With github-linguist/linguist#4614 Github understands "asddls" files und uses the syntax coloring provided by https://github.com/FreHu/abap-cds-grammar

I tried to extend this to also the "acds" file extension but failed due to too low usage of that file extension.
But we could add an override for this repo so that acds files just use the existing coloring for "asddls".
This is explained in: https://github.com/github/linguist/blob/master/docs/overrides.md
BeckerWdf added a commit that referenced this issue Jun 29, 2022
@BeckerWdf
Use ABAP CDS Syntax Highlighter for .acds files
a65c2e1 
With github-linguist/linguist#4614 Github understands "asddls" files and uses
the syntax coloring provided by
https://github.com/FreHu/abap-cds-grammar

Let's use an override for this repo so that acds files just use the
existing coloring for "asddls".
This is explained in:
https://github.com/github/linguist/blob/master/docs/overrides.md

Fixes: #371
@BeckerWdf BeckerWdf mentioned this issue Jun 29, 2022
Merged
BeckerWdf added a commit that referenced this issue Jun 29, 2022
@BeckerWdf
Use ABAP CDS Syntax Highlighter for .acds files (#372)
7fad0b6 
With github-linguist/linguist#4614 Github understands "asddls" files and uses
the syntax coloring provided by
https://github.com/FreHu/abap-cds-grammar

Let's use an override for this repo so that acds files just use the
existing coloring for "asddls".
This is explained in:
https://github.com/github/linguist/blob/master/docs/overrides.md

Fixes: #371
@larshp
Copy link
Collaborator

larshp commented Jun 29, 2022

ref github-linguist/linguist#5954

@BeckerWdf
Copy link
Contributor Author

Coloring is not perfect. See FreHu/abap-cds-grammar#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use ABAP CDS Syntax Highlighter for .acds files SAP/abap-file-formats
2 participants
@larshp @BeckerWdf