-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INTS] Add new object type INTS #670
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting the AFF. I have added a few comments. Since it is a big AFF and it is important that we understand how it works, would you be open for a meeting?
We have spoken within the team, could you please setup a meeting with me (Guilherme Saraiva), Nicolas Huber and Michael Schneider? We do not usually ask for meeting, but due to the urgency of the delivery and the complexity of the AFF, we think it is best. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sentence case means that only the first letter of the first word is capitalised.
Sorry that you changed all of the descriptions, they need to be reverted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added several comments now. In a first step, I would focus on structural changes of the AFF like: bindings
and binding_mappings
or signature*
, modeling*
and parameter*
.
Furthermore, an example would be nice to see the references of INTM
to INTS
.
I expect more feedback after this iteration.
I've done the changes. Please review and let me know in case of any comments. |
I've done then changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only made some comments regarding nameing of fields and titles
I had a look at recent changes. But I haven't managed to look into all details, yet. This object has a huge list of fields. @huber-nicolas gave some input on differences between the title (shorttext description) and the field name. If possible we should keep them in sync. However, whether you change the field name or the title is up to you. I guess, there we see anyhow further suggestions during UX review. But I would keep them in sync already. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @raghav6686. LGTM in my role as UX person
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two more small requests. But no crucial changes from my point of view.
I didn't went through completely, yet.
"scenarioType": "SAPGENAI", | ||
"scenarioTechnology": "SIDEBYSIDE", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, one more question: Is there only a predefine set of scenario types ans scenario technologies? If so, would it make sense to use an enumeration.
The same question came up for some further types like "usage type" or turnkey type below.
There are some more "_type" (except object type fields) and "_kind" fields in other structures that might raise the same question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had another look. We suggest to use enums wherever it is possible.
It should be also possible to specify allow list for enum values when implementing an ADT editor based on AFF.
No description provided.