Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EVTO] Add new object type EVTO #675

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[EVTO] Add new object type EVTO #675

wants to merge 7 commits into from
+179 −0

Conversation

apanys
Copy link
Contributor

@apanys apanys commented Dec 3, 2024

No description provided.

schneidermic0
schneidermic0 reviewed Dec 3, 2024
View reviewed changes
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

I have just checked your example object and added some questions/suggestions

file-formats/evto/examples/z_aff_example.evto.json Outdated Show resolved Hide resolved
file-formats/evto/examples/z_aff_example.evto.json Outdated Show resolved Hide resolved
file-formats/evto/examples/z_aff_example.evto.json Outdated Show resolved Hide resolved
@huber-nicolas huber-nicolas added the new-object This is a new object type added to AFF label Dec 3, 2024
schneidermic0
schneidermic0 reviewed Dec 4, 2024
View reviewed changes
file-formats/evto/type/zif_aff_evto_v1.intf.abap

"! <p class="shorttext">Major Version</p>
"! Major version
"! $minimum 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity. Version 0.0.1 is not an allowed value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly, we will default it with "1.0.0" and lower than that is not allowed.

schneidermic0
schneidermic0 reviewed Dec 4, 2024
View reviewed changes
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. Looks good to me 👍

I add the label that the object type is ready for UX review

@schneidermic0 schneidermic0 added the ux-review ready AFF is ready for UX review label Dec 4, 2024
@apanys
Copy link
Contributor Author

apanys commented Dec 4, 2024

Thanks a lot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schneidermic0 schneidermic0 schneidermic0 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
new-object This is a new object type added to AFF ux-review ready AFF is ready for UX review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apanys @schneidermic0 @huber-nicolas