[EDOI] Add new object types EDOI

[i506210]

No description provided.

[cla-assistant]

All committers have signed the CLA.

[cla-assistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[schneidermic0]

Hi @i506210,

Thank you for your contribution.

Would you mind to split this pull request (PR) into two PRs? One for EDOI and one for EDOT. I believe the handling for one PR per object type will be easier.

Furthermore, you might want to remove the .DS_Store files from the PR.

Thanks :)

[i506210]

Hi @i506210,

Thank you for your contribution.

Would you mind to split this pull request (PR) into two PRs? One for EDOI and one for EDOT. I believe the handling for one PR per object type will be easier.

Furthermore, you might want to remove the .DS_Store files from the PR.

Thanks :)

Hi @schneidermic0,

I have split Pull request into 2 and triggered PR. could you please check

Thanks & REgards,
Venkat

[Markus1812]

Hi Venkat,

thanks for the update. I've added some questions/comments to your pull request.

Please note, that for the title and description, we use title case and sentence case respectively. I've not marked every occurrence but if you could please adjust that.

"! <p class="shorttext">Interface Version</p>    "<- title (title case)
"! Interface version                             "<- description (sentence case)

[Markus1812]

Is this edocument_interface_id and interface_description the name and description of this EDOI object?

To prevent redundant data, the name is saved in the file name, and the description is saved in ty_main->header (where you currently have selected a header with description length 60, but there is also a version for length 80 or length 100 available).

[i506210]

May be I might have added 'header' by referring the sample interface. I don't know the purpose of 'header' section. If its not necessary, i will remove it.
Could you please explain the statement "the name is saved in the file name,", As I didn't find the field 'file name'.

[schneidermic0]

May be I might have added 'header' by referring the sample interface. I don't know the purpose of 'header' section. If its not necessary, i will remove it.

We expect formatVersionand header as mandatory fields. See https://github.com/SAP/abap-file-formats/blob/main/docs/json.md#writing-json-schema-with-abap-types

Therefore, please do not remove it ;)

Could you please explain the statement "the name is saved in the file name,", As I didn't find the field 'file name'.

If you check the file names in AFF, the object name is stored there. There is no need to add it to the file content. This would be redundant data.

[i506210]

corrected, removed object name and description from general information

[i506210]

Hi Venkat,

thanks for the update. I've added some questions/comments to your pull request.

Please note, that for the title and description, we use title case and sentence case respectively. I've not marked every occurrence but if you could please adjust that.

"! <p class="shorttext">Interface Version</p>    "<- title (title case)
"! Interface version                             "<- description (sentence case)

Hi

Hi Venkat,

thanks for the update. I've added some questions/comments to your pull request.

Please note, that for the title and description, we use title case and sentence case respectively. I've not marked every occurrence but if you could please adjust that.

"! <p class="shorttext">Interface Version</p>    "<- title (title case)
"! Interface version                             "<- description (sentence case)

Hi Michael,

I corrected all the places.

Thanks & Regards,
Venkat