chore: Reuse DotEnv instance and reduce log messages
#635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core/src/main/java/com/sap/ai/sdk/core/DestinationResolver.java
Outdated
Show resolved
Hide resolved
Merged
10 tasks
…cessor); And consider log level dynamically
…der' into cache-aicore-service-binding-loader
newtork
changed the title
DotEnv instance and reduce log messages
rpanackal
reviewed
Oct 29, 2025
Comment on lines
58
to
59
| final String logMessage = | ||
| "Found a service key in environment variable {}.\nUsing a service key is recommended for local testing only.\nBind the AI Core service to the application for productive usage.\n"; |
There was a problem hiding this comment.
(preference)
Here is a shorter version.
Suggested change
| final String logMessage = | |
| "Found a service key in environment variable {}.\nUsing a service key is recommended for local testing only.\nBind the AI Core service to the application for productive usage.\n"; | |
| final String logMessage = | |
| "Service key found in env {}. Recommended for local testing only. Prefer service binding in production."; |
There was a problem hiding this comment.
(Preference)
I like the longer message as it is more descriptive and (I think) clearer for the user what to do. But I would remove the newlines.
There was a problem hiding this comment.
I removed the newlines, prefer the "longer" version a little more as it is very precise and has a call to action.
…binding-loader # Conflicts: # docs/release_notes.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Related:
https://github.com/SAP/ai-sdk-java-backlog/issues/295
Feature scope:
Definition of Done
Tests cover the scope aboveError handling created / updated & covered by the tests aboveAligned changes with the JavaScript SDKDocumentation updated