Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Streaming azure openai #244

Open
wants to merge 64 commits into
base: main
Choose a base branch
from
Open

feat: Streaming azure openai #244

wants to merge 64 commits into from

Conversation

ZhongpinWang
Copy link
Contributor

@ZhongpinWang ZhongpinWang commented Oct 25, 2024 •
edited
Loading

Context

AI/gen-ai-hub-sdk-js-backlog#56.

Support streaming for azure-openai client in foundation-models.

Check sample-code for usage.

Definition of Done

  • Code is tested (Unit, E2E)
  • Error handling created / updated & covered by the tests above
  • [ ] Documentation updated Will be done in a separate PR
  • (Optional) Aligned changes with the Java SDK
  • (Optional) Release notes updated

@ZhongpinWang ZhongpinWang marked this pull request as ready for review November 11, 2024 13:45
jjtang1985
jjtang1985 reviewed Nov 13, 2024
View reviewed changes
Copy link
Contributor

@jjtang1985 jjtang1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some questions.

sample-code/src/server.ts Outdated Show resolved Hide resolved
packages/foundation-models/src/azure-openai/stream/sse-stream.ts Show resolved Hide resolved
sample-code/src/server.ts Show resolved Hide resolved
sample-code/src/server.ts Show resolved Hide resolved
jjtang1985
jjtang1985 approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@jjtang1985 jjtang1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the API from the consumer perspective.
LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjtang1985 jjtang1985 jjtang1985 approved these changes

@KavithaSiva KavithaSiva Awaiting requested review from KavithaSiva

@deekshas8 deekshas8 Awaiting requested review from deekshas8

@MatKuhr MatKuhr Awaiting requested review from MatKuhr

@tomfrenken tomfrenken Awaiting requested review from tomfrenken

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZhongpinWang @jjtang1985 @MatKuhr @deekshas8