fix: Use types instead of interfaces #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
deekshas8
reviewed
Nov 7, 2024
Co-authored-by: Deeksha Sinha <[email protected]>
deekshas8
reviewed
Nov 7, 2024
| @@ -10,12 +10,12 @@ import type { LlmChoice } from './llm-choice.js'; | |||
| /** | |||
| * Results of each module. | |||
| */ | |||
| export interface ModuleResults { | |||
| export type ModuleResults = { | |||
| grounding?: GenericModuleResult; | |||
There was a problem hiding this comment.
[req] We removed the grounding types from input, but this is still here
There was a problem hiding this comment.
This would also need a compatibility note.
There was a problem hiding this comment.
- removed the grounding key
- added compatibility note
deekshas8
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Due to some eslint rules, we used interfaces for some of the orchestration types by accident.
In order to keep the consistent UX, we will keep the original generated client.
Definition of Done