Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Regenerate grounding clients with a default base path #393

Merged
merged 11 commits into from
Jan 3, 2025

Conversation

KavithaSiva
Copy link
Contributor

@KavithaSiva KavithaSiva commented Dec 20, 2024

Context

SAP/ai-sdk-js-backlog#187.

The OpenAPI generator in Cloud SDK, was updated to also make use of basePath from options-per-service.json file.
This PR regenerates the grounding client.

openapi-request-builder also has to be adapted to use the basePath

@KavithaSiva KavithaSiva marked this pull request as ready for review December 20, 2024 23:48
@KavithaSiva KavithaSiva added the blocked Issue or PR blocked due to other issues. label Jan 3, 2025
…nges

# Conflicts:
#	packages/document-grounding/src/client/api/retrieval-api.ts
#	packages/document-grounding/src/client/api/vector-api.ts
#	packages/document-grounding/src/spec/api.yaml
#	packages/document-grounding/src/tests/collections-api.test.ts
#	packages/document-grounding/src/tests/documents-api.test.ts
#	packages/document-grounding/src/tests/retrieval-api.test.ts
#	sample-code/src/document-grounding.ts
@ZhongpinWang ZhongpinWang removed the blocked Issue or PR blocked due to other issues. label Jan 3, 2025
@KavithaSiva KavithaSiva changed the title chore: Regenerate grounding clients chore: Regenerate grounding clients with basePath Jan 3, 2025
@KavithaSiva KavithaSiva changed the title chore: Regenerate grounding clients with basePath chore: Regenerate grounding clients with a default base path Jan 3, 2025
Copy link
Contributor

@ZhongpinWang ZhongpinWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KavithaSiva KavithaSiva merged commit 0a5ef16 into main Jan 3, 2025
12 checks passed
@KavithaSiva KavithaSiva deleted the chore/update-openapi-basePath-changes branch January 3, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants