chore: Spec Update Automation #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatKuhr
changed the title
ZhongpinWang
requested changes
Jan 21, 2025
ZhongpinWang
approved these changes
Jan 22, 2025
| # Compilation can easily fail e.g. from re-namings and has to be fixed manually. | ||
| # Thus, this action raises the PR anyway and only reports success or failure of compilation and testing. | ||
| run: | | ||
| if pnpm compile ; then |
There was a problem hiding this comment.
[pp] Well, technically this step is not needed because compile is part of pnpm install. But anyway won't hurt to keep it similar to java version.
There was a problem hiding this comment.
this compile is needed because install is before generate, so after generate the code has changed 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
SAP/ai-sdk-js-backlog#66.
What this PR does and why it is needed
One job to rule all specs 😉