Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Regenerate AI Core client with a default base path #478

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

KavithaSiva
Copy link
Contributor

@KavithaSiva KavithaSiva commented Jan 22, 2025

Context

Closes SAP/ai-sdk-js-backlog#ISSUENUMBER.

What this PR does and why it is needed

This PR regenerates the AI Core client after cloud sdk generator changes for accounting for a basePath.
As, we don't have anything that accounts for basePath in this spec, the regenerated clients have this property set to undefined.

@KavithaSiva KavithaSiva marked this pull request as ready for review January 22, 2025 12:17
@KavithaSiva KavithaSiva changed the title chore: regenerate AI Core client chore: Regenerate AI Core client Jan 22, 2025
@KavithaSiva KavithaSiva changed the title chore: Regenerate AI Core client chore: Regenerate AI Core client with a default base path Jan 22, 2025
@MatKuhr MatKuhr merged commit b8be289 into main Jan 22, 2025
13 of 14 checks passed
@MatKuhr MatKuhr deleted the feat/regenerate-ai-core-client branch January 22, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants