feat: 🎸 [JIRA:HCPSDKFIORIUIKIT-2700] Object Cell Enhancement #877
+222
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hengyi-zhang
requested review from
billzhou0223
and removed request for
a team
dyongxu
reviewed
Nov 12, 2024
Apps/Examples/Examples/FioriSwiftUICore/ObjectItem/ObjectCellEnhancementExample.swift
Outdated
Show resolved
Hide resolved
dyongxu
reviewed
Nov 12, 2024
Apps/Examples/Examples/FioriSwiftUICore/ObjectItem/ObjectItemExample.swift
Outdated
Show resolved
Hide resolved
dyongxu
reviewed
Nov 12, 2024
Apps/Examples/Examples/FioriSwiftUICore/ObjectItem/ObjectCellEnhancementExample.swift
Outdated
Show resolved
Hide resolved
dyongxu
reviewed
Nov 12, 2024
Apps/Examples/Examples/FioriSwiftUICore/ObjectItem/ObjectCellEnhancementExample.swift
Outdated
Show resolved
Hide resolved
dyongxu
reviewed
Nov 12, 2024
Apps/Examples/Examples/FioriSwiftUICore/ObjectItem/ObjectCellEnhancementExample.swift
Outdated
Show resolved
Hide resolved
dyongxu
requested changes
Nov 12, 2024
There was a problem hiding this comment.
- I suggested some test code change. Pls don't commit that directly from github(It will fail the build since the direct commit does not include a keyword in the commit message)
- Can you review the screen with Xiaoyu to see if the "overflow" button alignment is correct? (It does not look correct to me)
@hengyi-zhang @xiaoyu0722 Can you review the overflow button alignment is correct ?
|
billzhou0223
requested changes
Nov 13, 2024
| protocol _ObjectItemComponent: _TitleComponent, _SubtitleComponent, _FootnoteComponent, _DescriptionComponent, _StatusComponent, _SubstatusComponent, _DetailImageComponent, _IconsComponent, _AvatarsComponent, _FootnoteIconsComponent, _FootnoteIconsTextComponent, _TagsComponent, _ActionComponent {} | ||
| protocol _ObjectItemComponent: _TitleComponent, _SubtitleComponent, _FootnoteComponent, _DescriptionComponent, _StatusComponent, _SubstatusComponent, _DetailImageComponent, _IconsComponent, _AvatarsComponent, _FootnoteIconsComponent, _FootnoteIconsTextComponent, _TagsComponent, _ActionComponent { | ||
| // sourcery: @ViewBuilder | ||
| var objectItemButton: FioriButton? { get } |
There was a problem hiding this comment.
What's this button used for?
An action usually should have its own component protocol like ActionComponent.
There was a problem hiding this comment.
The objectItemButton for accessory enhancement
No problem for the alignment. |
dyongxu
approved these changes
Nov 13, 2024
dyongxu
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.