feat(openapi-generator): Add optional logic to suppress faulty additionalProperties: true
#689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newtork
added
please merge
newtork
commented
Jan 10, 2025
| """; | ||
| final Order order = Order.create().productId(100L).quantity(5).totalPrice(6.0f); | ||
| order.setCustomField("shoesize", 44); | ||
| assertThat(new ObjectMapper().writeValueAsString(order)).isEqualToIgnoringWhitespace(expected); |
There was a problem hiding this comment.
(Comment)
Without the enabled feature toggle this test assertion fails:
Expecting actual:
"{}"
to be equal to:
"{
"productId": 100,
"quantity": 5,
"totalPrice": 6.0,
"packaging" : "bottle",
"shoesize": 44
}
MatKuhr
reviewed
Jan 13, 2025
| @@ -75,6 +76,25 @@ void testJacksonSerialization() | |||
| assertThat(new ObjectMapper().writeValueAsString(obj)).isEqualToIgnoringWhitespace(expected); | |||
| } | |||
|
|
|||
| @Test | |||
| void testJacksonSerializeOrder() | |||
There was a problem hiding this comment.
a deserialization test would also be helpful, right?
| @@ -126,6 +126,7 @@ | |||
| <pojoConstructorVisibility>protected</pojoConstructorVisibility> | |||
| <useOneOfInterfaces>true</useOneOfInterfaces> | |||
| <enumUnknownDefaultCase>true</enumUnknownDefaultCase> | |||
| <stopAdditionalProperties>true</stopAdditionalProperties> | |||
There was a problem hiding this comment.
considering this never worked, isn't this essentially a bugfix and thus doesn't require a feature flag?
| * effectively disabling serialization. Jackson by default only serializes the map entries and will ignore all | ||
| * fields from the model class. | ||
| */ | ||
| STOP_ADDITIONAL_PROPERTIES("stopAdditionalProperties", "false"); |
There was a problem hiding this comment.
+1 for keeping track of the flags, but then we should add all of our internal flags here for consistency, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
https://github.tools.sap/AI/ai-sdk-java-backlog/issues/129
additionalProperties: truewill appendextends HashMap<String,Object>to generated class signature. See intermediate commit 7bd61edserialVersionUID. See 7bd61ed#r151192960super#entrySet().However
Feature scope:
Definition of Done
Error handling created / updated & covered by the tests aboveDocumentation updatedRelease notes updated