Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validated setAllowedOrigins and setIgnoredOrigins methods. Updated security docs. #147

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Validated setAllowedOrigins and setIgnoredOrigins methods. Updated security docs. #147

wants to merge 2 commits into from

Conversation

horatzio-sap
Copy link
Contributor

No description provided.

@horatzio-sap
Copy link
Contributor Author

@kistll or @zaheral The behavior related to allowedOrigins is very weird.
If no allowedOrigins are set, then it actually allows all origins by default.
I'm not sure this is right. Would you happen to have any insight on why Sebastian implemented it this way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaheral zaheral Awaiting requested review from zaheral

@kistll kistll Awaiting requested review from kistll

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@horatzio-sap @HoratzioInfiniswiss