Skip to content

Commit

Permalink
fix(platform): table showing info bar with selected filters
Browse files Browse the repository at this point in the history
closes [#11783](#11783)

## Description

- Moved hardcoded "Filtered by" string into translation file
  • Loading branch information
khotcholava committed Oct 23, 2024
1 parent 18e0d8c commit f600751
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 6 deletions.
1 change: 1 addition & 0 deletions libs/i18n/src/lib/models/fd-language-key-identifier.ts
Original file line number Diff line number Diff line change
Expand Up @@ -427,6 +427,7 @@ export type FdLanguageKeyIdentifier =
| 'platformTable.deselectSingleRow'
| 'platformTable.selectSingleRow'
| 'platformTable.loadMore'
| 'platformTable.filteredBy'
| 'platformWizardGenerator.summarySectionEditStep'
| 'platformMessagePopover.allErrors'
| 'platformMessagePopover.defaultErrors.email'
Expand Down
2 changes: 2 additions & 0 deletions libs/i18n/src/lib/translations/translations.properties
Original file line number Diff line number Diff line change
Expand Up @@ -846,6 +846,8 @@ platformTable.deselectSingleRow = To deselect row, press SPACEBAR
platformTable.selectSingleRow = To select row, press SPACEBAR
#XBUT Label for the button, which loads additional rows
platformTable.loadMore = Load more
#XBUT Label for applied filter table toolbar
platformTable.filteredBy = Filtered by
#XBUT Label for the button, navigates to the edit section of the wizard
platformWizardGenerator.summarySectionEditStep = Edit
#XBUT Label for the button, which activates the list of all errors in message popover
Expand Down
11 changes: 6 additions & 5 deletions libs/i18n/src/lib/translations/translations.ts
Original file line number Diff line number Diff line change
Expand Up @@ -168,10 +168,10 @@ export default {
decreasePeriodLabel: 'Decrease period',
navigationInstruction:
'To move between items in this list, press top arrow or bottom arrow. To switch between lists press left arrow or right arrow.',
nightLabel: 'night',
morningLabel: 'morning',
afternoonLabel: 'afternoon',
eveningLabel: 'evening'
nightLabel: 'at night',
morningLabel: 'in the morning',
afternoonLabel: 'in the afternoon',
eveningLabel: 'in the evening'
},
coreTimePicker: {
timePickerInputLabel: 'Time picker input',
Expand Down Expand Up @@ -514,7 +514,8 @@ export default {
deselectAllCheckboxLabel: 'Deselect all',
deselectSingleRow: 'To deselect row, press SPACEBAR',
selectSingleRow: 'To select row, press SPACEBAR',
loadMore: 'Load more'
loadMore: 'Load more',
filteredBy: 'Filtered by'
},
platformWizardGenerator: {
summarySectionEditStep: 'Edit'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@
[headingLevel]="headingLevel"
>
<label fd-toolbar-label>
Filtered by:
{{ 'platformTable.filteredBy' | fdTranslate }}:
@for (filter of appliedFilters(); track filter.columnName; let i = $index) {
{{ filter.columnName }} ({{ filter.params }})
@if (i < appliedFilters().length - 1) {
Expand Down

0 comments on commit f600751

Please sign in to comment.