Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform): Update info bar table to reflect selected filters #12634

Merged
merged 10 commits into from
Nov 6, 2024

Conversation

khotcholava
Copy link
Contributor

fix(platform): table showing info bar with selected filters

closes #11783

  • Implemented an info bar beneath the table toolbar to display active filters, following SAP Fiori design recommendations.
  • Used <fd-toolbar fdType="info" [active]="true"> from Fundamental NGX.
  • Displayed filter information with the correct format
  • Included a "decline" icon in the info bar.
  • Info bar appears only when a filter is applied and hides once the filter is reset.
  • Added feature to close the popover when the dismiss button is clicked. The popover will reappear upon changing the filters.

khotcholava and others added 2 commits October 21, 2024 17:44
closes [#11783](#11783)

- Implemented an info bar beneath the table toolbar to display active filters, following SAP Fiori design recommendations.
- Used <fd-toolbar fdType="info" [active]="true"> from Fundamental NGX.
- Displayed filter information with the correct format
- Included a "decline" icon in the info bar.
- Info bar appears only when a filter is applied and hides once the filter is reset.
closes [#11783](#11783)

- Added feature to close the popover when the dismiss button is clicked. The popover will reappear upon changing the filters.
@khotcholava khotcholava self-assigned this Oct 22, 2024
@khotcholava khotcholava marked this pull request as draft October 22, 2024 09:08
@khotcholava
Copy link
Contributor Author

NOTE:

!!! Not yet ready for review !!!

Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit e736a33
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/67176b6b0dca670008e1b8da
😎 Deploy Preview https://deploy-preview-12634--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit b385032
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/6720d1a52f6771000862e8d3
😎 Deploy Preview https://deploy-preview-12634--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Oct 22, 2024

Visit the preview URL for this PR (updated for commit b385032):

https://fundamental-ngx-gh--pr12634-11783-infobar-showin-44silskm.web.app

(expires Fri, 01 Nov 2024 12:18:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

closes [#11783](#11783)

## Description

- Moved hardcoded "Filtered by" string into translation file
@khotcholava khotcholava marked this pull request as ready for review October 23, 2024 21:52
Copy link
Member

@mikerodonnell89 mikerodonnell89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things in this screenshot:

  • [object Object]
  • I think we need the compact button
Screenshot 2024-10-24 at 12 58 24 PM

@droshev droshev added this to the Sprint 139 - October 2024 milestone Oct 24, 2024
closes [#11783](#11783)

## Description
Added fcCompact to table toolbar fliter close button.
@InnaAtanasova
Copy link
Contributor

Still shows [object Object]
Screenshot 2024-10-28 at 9 45 38 AM

khotcholava and others added 3 commits October 29, 2024 13:29
closes [#11783](#11783)

## Description
 Update _setAppliedFilterNames function to properly format nested parameters
…ers' into 11783-infobar-showing-table-filters
closes [#11783](#11783)

- Added reset filter functionality on close toolbar click
- Removed logs
- Clean up the code
@droshev droshev merged commit 755d38a into main Nov 6, 2024
19 checks passed
@droshev droshev deleted the 11783-infobar-showing-table-filters branch November 6, 2024 21:18
@do-oel
Copy link

do-oel commented Nov 7, 2024

Thanks for this fix! Highly appreciated.

Two smaller things for improvement:

  1. The filter info bar shows an index number in front of the filter term. This should be hidden (e.g, Filtered by: StatusColor (0: positive)
  2. The category name is using no spaces, this seems a bit weird (e.g, StatusColor instead of Status Color)
image

@khotcholava
Copy link
Contributor Author

@do-oel Can you please create stackblitz example for reproducing this issue?

@do-oel
Copy link

do-oel commented Nov 19, 2024

Hi @khotcholava, you can experience the issue in the documentation example: https://sap.github.io/fundamental-ngx/#/platform/table/settings-dialog-table#filterable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Infobar showing applied filters in platform table
5 participants