feat(platform): add dropdown menu for predefined filter options #12859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Check the deploy log for errors here: https://app.netlify.com/sites/fundamental-ngx/deploys
|
mikerodonnell89
requested changes
Jan 6, 2025
There was a problem hiding this comment.
@mohammad-nmeri Sorry, but before we can review, commit messages must adhere to these rules for release log generation purposes: https://github.com/SAP/fundamental-ngx/blob/main/CONTRIBUTING.md#commit
mohammad-nmeri
changed the title
|
@mikerodonnell89, apologies for the oversight. I have updated the commit message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the filtering dialog in the Platform App by adding a dropdown for selecting predefined filter options. It introduces a new filterValuesOptions attribute in the columns component, which expects a string array of predefined filter values to be sent when defining a column. These values will be displayed in the filter dropdown, improving the filtering experience. Additionally, a new "Array" data type for columns is implemented to support this functionality.
Screenshots
Before:
After: