-
Notifications
You must be signed in to change notification settings - Fork 135
[WIP] feat(core, platform): adopt styles breaking changes part two #13509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
InnaAtanasova
wants to merge
9
commits into
main
Choose a base branch
from
feat/adopt-styles-breaking-changes-part-two
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
534859a to
796b60f
Compare
…13506) * fix(core): adopt a11y breaking changes for Textarea states * fix(core): a11y for input and textarea
* feat(core, platform): adopt styles breaking changes part two * fix(core): adopt a11y changes for message strip * fix(core): uncomment docs * fix(core): update translations * fix(core): fix lint * fix(core): use signals all the way * fix(core): use ngAfterContentChecked instead of ngAfterContentInit --------- Co-authored-by: Inna Atanasova <[email protected]>
e72bbb5 to
2914dc3
Compare
* feat(core): adopt breaking changes for object number * feat(core): add interactive and inverted inputs, update examples * fix(core): update some unit tests * fix(core): resolve some comments
* fix(core): adopt object status breaking changes, update core examples * refactor(core): turn all inputs into signals * test(core): add some unit tests * fix(core): address PR comments * fix(core): fix FdLanguage interface
* feat(core): accommodate link accessibility changes * fix(core): address PR comments
* fix(core): adopt breaking changes for object identifier * fix(core): add aria-describedby for the Link element in Obj Identifier * fix(core): update logic for setting aria-describedby, add unit tests * fix(core): resolve comment --------- Co-authored-by: Inna Atanasova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
accessibility
use this label for any issue or enhancement related to screenreader/keyboard/etc support
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
closes #13490
Description
Contains all the components done during the second phase for a11y improvements