-
Notifications
You must be signed in to change notification settings - Fork 135
feat: bring ui5wc generator #13511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: bring ui5wc generator #13511
Conversation
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
8461b75
to
a8bfd50
Compare
abstract name: string; | ||
|
||
protected availableThemes = signal<string[]>(supportedThemes); | ||
|
||
protected _globalThemingService: Ui5ThemingService | null = inject(Ui5ThemingService, { optional: true }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add some typedocs for these
supportsTheme(theme: string): boolean | Promise<boolean> { | ||
return this.availableThemes().includes(theme); | ||
} | ||
|
||
getAvailableThemes(): string[] | Promise<string[]> { | ||
return this.availableThemes(); | ||
} | ||
|
||
async setTheme(theme: string): Promise<boolean> { | ||
const supported = this.availableThemes().includes(theme); | ||
if (supported) { | ||
setTheme(theme); | ||
} | ||
return supported; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
|
implementation of the ui5wc wrapper and the 4 packages
part of #13176